Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal direction specific class names set in variables #39161

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pau1phi11ips
Copy link

@pau1phi11ips pau1phi11ips commented Sep 8, 2023

Allows start/end class names to be overridden in a build step to ease the migration from Bootstrap 4 to Bootstrap 5.

Motivation & Context

An old project wouldn't have to rename every *-left, *-right, text-align-*, ml*, mr*, pl*, pr* class in a codebase.
Settings to use the Bootstrap 4 class names:

$start:                      left;
$s:                          l;
$end:                        right;
$e:                          r;

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • N/A My change introduces changes to the documentation
  • N/A I have updated the documentation accordingly
  • N/A I have added tests to cover my changes
  • All new and existing tests passed

Live previews

No changes to end CSS

Related issues

None

Allows start/end class names to be overridden in a build step to ease the migration from BS4 to BS5
@pau1phi11ips pau1phi11ips requested a review from a team as a code owner September 8, 2023 20:25
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the small version of start/end should just be $s and $e?

@pau1phi11ips pau1phi11ips force-pushed the main branch 2 times, most recently from ae2a99d to 425236f Compare November 13, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants