Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make theme selector tick icon visible when active in examples layout #39177

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 13, 2023

Description

This PR uses the existing .bd-mode-toggle selector to force-switch the display value of the icon when active directly in the style of the layout of the examples. It's done based on the same principle as the following in site/assets/_navbar.scss:

.bd-navbar .dropdown-menu .active .bi {
  display: block !important;
}

I'm not a big fan of the current solution (even for the navbar) but this fix stays in the same spirit.

New rendering

Screenshot 2023-09-13 at 23 14 49

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39175

@julien-deramond julien-deramond marked this pull request as ready for review September 13, 2023 21:15
@XhmikosR XhmikosR merged commit 8df9899 into main Sep 14, 2023
13 checks passed
@XhmikosR XhmikosR deleted the main-jd-fix-tick-icon-in-examples-layout branch September 14, 2023 14:01
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can't see theme selector tick icon in examples
3 participants