Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Handle border-radii and border in an easier way #39328

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 23, 2023

Description

Refactoring of the examples to have a more consistent UX.
Fixes some small issues and particularly the border-radius issues.

Motivation & Context

Ease the CSS associated to .bd-code-snippet and make the docs more consistent.
It's the first part of #38933 and #39274.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Will help on #38933 and #39274.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of copy changes to make it clearer in the browser what we're supposed to see with the docsref page.

site/content/docs/5.3/docsref.md Outdated Show resolved Hide resolved
site/content/docs/5.3/docsref.md Outdated Show resolved Hide resolved
site/content/docs/5.3/docsref.md Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton force-pushed the main-lmp-docs-example-refactoring branch from e4dc2d2 to c970476 Compare November 15, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants