Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient contrast on borders #40949

Conversation

GhassenRjab
Copy link

@GhassenRjab GhassenRjab commented Oct 16, 2024

Description

Use $gray-600 for border color in light mode.
This has a contrast of 4.69 to white, which should be good

Motivation & Context

This solves the insufficient contrast on borders when on light mode. Issue opened here: #38480

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

No related issues.

This has a contrat of 4.69 to white, which should be good
@GhassenRjab GhassenRjab requested a review from a team as a code owner October 16, 2024 04:26
@julien-deramond
Copy link
Member

Thanks for your PR @GhassenRjab, but the suggested value is too dark. A lighter one was already refused in #38489.
As said here #38489 (comment):

Let's keep the PRs at bay for now and discuss any potential changes in the issue. I could see us darkening things a little, but this is too much.

@GhassenRjab GhassenRjab deleted the fix/insufficient-contrast-for-borders branch October 17, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants