-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): derive Default
for ActionRow
#1772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlikely for Discord to break this type's API (where default is impossible)
What's the motivation? |
Mostly because of #1752 let components = ComponentsBuilder()::new()
.action_row(ActionRow { components: Vec::new() })
.build(); or just let components = ComponentsBuilder()::new()
.action_row(Default::default())
.build(); Also as vilgotf has said it's unlikely that |
Why would one want an empty action row? |
I saw quite a few use cases where people start with an empty action row and populated it later. |
I'm not personally convinced from the examples provided that it's worth making this commitment. It feels like if one has a ComponentsBuilder then an |
I'm also not in favor of this change. Going to give this a close. |
Since action rows only contain a components vector deriving default should be no problem.