Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lavalink)!d-breaking: Moving the current lavalink implementation to v3 folder #2321

Closed

Conversation

LinuxDevon
Copy link
Contributor

In preparations for the new v4 which requires some massive changes. I am putting in a sub module so users can use it unaffected for now.

Going to make a v4 folder for the overhaul. I experimented with how to interact with it and most of it is now using REST API for v4 of lavalink. This breaks the interface we have setup with all of the structs changing and the core outgoing changing as well. I want to make some refactoring of the code in this change since imo the implementation exposes a bit too much detail. I want these changes to be easier to read and understand for v4. This also allows existing users to prefix v3:: if they are not ready to upgrade or change

#2192

In preparations for the new v4 which requires some massive changes. I am putting in a sub module so users can use it unaffected for now
@github-actions github-actions bot added the c-lavalink Affects the lavalink crate label Mar 10, 2024
@LinuxDevon LinuxDevon changed the title Moving the current lavalink implementation to v3 folder refactor(lavalink)d-breaking: Moving the current lavalink implementation to v3 folder Mar 10, 2024
@Gelbpunkt
Copy link
Member

Since this is a breaking change... You can just straight up remove it all and add the new v4 implementation at the crate root. Just make sure your PR targets next.

@github-actions github-actions bot added the c-book Affects the book label Mar 10, 2024
@LinuxDevon LinuxDevon changed the title refactor(lavalink)d-breaking: Moving the current lavalink implementation to v3 folder refactor(lavalink)!d-breaking: Moving the current lavalink implementation to v3 folder Mar 10, 2024
@LinuxDevon
Copy link
Contributor Author

LinuxDevon commented Mar 10, 2024

I will do that @Gelbpunkt. Do you want me to close this and just open one with the new v4? Or have this folder for a bit to maintain the compatibility while v4 gets tested?

Not sure how long it is going to take for me to implement it.

@Gelbpunkt
Copy link
Member

I will do that @Gelbpunkt. Do you want me to close this and just open one with the new v4? Or have this folder for a bit to maintain the compatibility while v4 gets tested?

Not sure how long it is going to take for me to implement it.

Testing should happen in a PR, not in the main branches, so no, you don't need to keep the old version around.

@LinuxDevon
Copy link
Contributor Author

Closing to just do the refactoring in the branch. No need for v3 to be kept around

@LinuxDevon LinuxDevon closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-book Affects the book c-lavalink Affects the lavalink crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants