chore(deps): update dependency @apollo/server to v4.9.3 [security] - autoclosed #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
4.1.0
->4.9.3
GitHub Vulnerability Alerts
GHSA-j5g3-5c8r-7qfx
Impact
What kind of vulnerability is it?
Apollo Server can log sensitive information (Studio API keys) if they are passed incorrectly (with leading/trailing whitespace) or if they have any characters that are invalid as part of a header value.
Who is impacted?
Users who (all of the below):
node-fetch
) or configured their ownnode-fetch
fetcherThe following node snippet can test whether your API key has invalid header values. This code is taken directly from
node-fetch@2
's header value validation code.If the provided API key is not a valid header value, whenever Apollo Server uses that API key in a request (to Studio, for example),
node-fetch
will throw an error which contains the header value. This error is logged in various ways depending on the user's configuration, but most likely the console or some configured logging service.Patches
This problem is patched in the latest version of Apollo Server as soon as this advisory is published.
Workarounds
fetcher
Solution
.trim()
on incoming API keys in order to eliminate leading/trailing whitespace and log a warning when it does so.node-fetch@2
performs on header values on startup. Apollo Server will throw an error on startup (i.e., fail to start completely) and notify the user their API key is invalid along with the offending characters.Release Notes
apollographql/apollo-server (@apollo/server)
v4.9.3
Compare Source
Patch Changes
a1c725eaf
Thanks @trevor-scheer! - Ensure API keys are valid header values on startupApollo Server previously performed no sanitization or validation of API keys on startup. In the case that an API key was provided which contained characters that are invalid as header values, Apollo Server could inadvertently log the API key in cleartext.
This only affected users who:
node-fetch
fetcherApollo Server now trims whitespace from API keys and validates that they are valid header values. If an invalid API key is provided, Apollo Server will throw an error on startup.
For more details, see the security advisory:
GHSA-j5g3-5c8r-7qfx
v4.9.2
Compare Source
Patch Changes
#7699
62e7d940d
Thanks @trevor-scheer! - Fix error path attachment for list itemsPreviously, when errors occurred while resolving a list item, the trace builder would fail to place the error at the correct path and just default to the root node with a warning message:
This change places these errors at their correct paths and removes the log.
v4.9.1
Compare Source
Patch Changes
ebfde0007
Thanks @trevor-scheer! - Add missingnonce
onscript
tag for non-embedded landing pagev4.9.0
Compare Source
Minor Changes
#7617
4ff81ca50
Thanks @trevor-scheer! - Introduce newApolloServerPluginSubscriptionCallback
plugin. This plugin implements the subscription callback protocol which is used by Apollo Router. This feature implements subscriptions over HTTP via a callback URL which Apollo Router registers with Apollo Server. This feature is currently in preview and is subject to change.You can enable callback subscriptions like so:
Note that there is currently no tracing or metrics mechanism in place for callback subscriptions. Additionally, this plugin "intercepts" callback subscription requests and bypasses some of Apollo Server's internals. The result of this is that certain plugin hooks (notably
executionDidStart
andwillResolveField
) will not be called when handling callback subscription requests or when sending subscription events.For more information on the subscription callback protocol, visit the docs:
https://www.apollographql.com/docs/router/executing-operations/subscription-callback-protocol/
Patch Changes
4784f46fb
Thanks @renovate! - Update graphql-http dependencyv4.8.1
Compare Source
Patch Changes
42fc65cb2
Thanks @trevor-scheer! - Update test suite for compatibility with Node v20v4.8.0
Compare Source
Minor Changes
#7634
f8a8ea08f
Thanks @dfperry5! - Updating the ApolloServer constructor to take in a stringifyResult function that will allow a consumer to pass in a function that formats the result of an http query.Usage:
v4.7.5
Compare Source
Patch Changes
#7614
4fadf3ddc
Thanks @Cellule! - Publish TypeScript typings for CommonJS modules output.This allows TypeScript projects that use CommonJS modules with
moduleResolution: "node16"
ormoduleResolution: "nodeNext"
to correctly resolves the typings of apollo's packages as CommonJS instead of ESM.
Updated dependencies [
4fadf3ddc
]:v4.7.4
Compare Source
Patch Changes
0adaf80d1
Thanks @trevor-scheer! - Address Content Security Policy issuesThe previous implementation of CSP nonces within the landing pages did not take full advantage of the security benefit of using them. Nonces should only be used once per request, whereas Apollo Server was generating one nonce and reusing it for the lifetime of the instance. The reuse of nonces degrades the security benefit of using them but does not pose a security risk on its own. The CSP provides a defense-in-depth measure against a potential XSS, so in the absence of a known XSS vulnerability there is likely no risk to the user.
The mentioned fix also coincidentally addresses an issue with using crypto functions on startup within Cloudflare Workers. Crypto functions are now called during requests only, which resolves the error that Cloudflare Workers were facing. A recent change introduced a
precomputedNonce
configuration option to mitigate this issue, but it was an incorrect approach given the nature of CSP nonces. This configuration option is now deprecated and should not be used for any reason since it suffers from the previously mentioned issue of reusing nonces.Additionally, this change adds other applicable CSPs for the scripts, styles, images, manifest, and iframes that the landing pages load.
A final consequence of this change is an extension of the
renderLandingPage
plugin hook. This hook can now return an object with anhtml
property which returns aPromise<string>
in addition to astring
(which was the only option before).v4.7.3
Compare Source
Patch Changes
#7601
75b668d9e
Thanks @trevor-scheer! - Provide a new configuration option for landing page pluginsprecomputedNonce
which allows users to provide a nonce and avoid calling intouuid
functions on startup. This is useful for Cloudflare Workers where random number generation is not available on startup (only during requests). Unless you are using Cloudflare Workers, you can ignore this change.The example below assumes you've provided a
PRECOMPUTED_NONCE
variable in yourwrangler.toml
file.Example usage:
v4.7.2
Compare Source
Patch Changes
c3f04d050
Thanks @trevor-scheer! - Update@apollo/utils.usagereporting
dependency. Previously, installing@apollo/gateway
and@apollo/server
could result in duplicate / differently versioned installs of@apollo/usage-reporting-protobuf
. This is because the@apollo/server-gateway-interface
package was updated to use the latest protobuf, but the@apollo/utils.usagereporting
package was not. After this change, users should always end up with a single install of the protobuf package when installing both@apollo/server
and@apollo/gateway
latest versions.v4.7.1
Compare Source
Patch Changes
5d3c45be9
Thanks @mayakoneval! - 🐛 Bug Fix for Apollo Server Landing Pages on Safari. A Content Security Policy was added to our landing page html so that Safari can run the inline scripts we use to call the Embedded Sandbox & Explorer.v4.7.0
Compare Source
Minor Changes
#7504
22a5be934
Thanks @mayakoneval! - In the Apollo Server Landing Page Local config, you can now opt out of the telemetry that Apollo Studio runs in theembedded Sandbox & Explorer landing pages. This telemetry includes Google Analytics for event tracking and
Sentry for error tracking.
Example of the new config option:
v4.6.0
Compare Source
Minor Changes
#7465
1e808146a
Thanks @trevor-scheer! - Introduce new opt-in configuration option to mitigate v4 status code regressionApollo Server v4 accidentally started responding to requests with an invalid
variables
object with a 200 status code, where v3 previously responded with a 400. In order to not break current behavior (potentially breaking users who have creatively worked around this issue) and offer a mitigation, we've added the following configuration option which we recommend for all users.Specifically, this regression affects cases where input variable coercion fails. Variables of an incorrect type (i.e.
String
instead ofInt
) or unexpectedlynull
are examples that fail variable coercion. Additionally, missing or incorrect fields on input objects as well as custom scalars that throw during validation will also fail variable coercion. For more specifics on variable coercion, see the "Input Coercion" sections in the GraphQL spec.This will become the default behavior in Apollo Server v5 and the configuration option will be ignored / no longer needed.
Patch Changes
#7454
f6e3ae021
Thanks @trevor-scheer! - Start building packages with TS 5.x, which should have no effect for users#7433
e0db95b96
Thanks @KGAdamCook! - Previously, when users provided their owndocumentStore
, Apollo Server used a random prefix per schema in order to guarantee there was no shared state from one schema to the next. Now Apollo Server uses a hash of the schema, which enables the provided document store to be shared if you choose to do so.v4.5.0
Compare Source
Minor Changes
#7431
7cc163ac8
Thanks @mayakoneval! - In the Apollo Server Landing Page Local config, you can now automatically turn off autopolling on your endpoints as well as pass headers used to introspect your schema, embed an operation from a collection, and configure whether the endpoint input box is editable. In the Apollo Server Landing Page Prod config, you can embed an operation from a collection & we fixed a bug introduced in release 4.4.0Example of all new config options:
#7430
b694bb1dd
Thanks @mayakoneval! - We now send your @apollo/server version to the embedded Explorer & Sandbox used in the landing pages for analytics.Patch Changes
#7432
8cbc61406
Thanks @mayakoneval! - Bug fix: TL;DR revert a previous change that stops passing includeCookies from the prod landing page config.Who was affected?
Any Apollo Server instance that passes a
graphRef
to a production landing page with a non-defaultincludeCookies
value that does not match theInclude cookies
setting on your registered variant on studio.apollographql.com.How were they affected?
From release 4.4.0 to this patch release, folks affected would have seen their Explorer requests being sent with cookies included only if they had set
Include cookies
on their variant. Cookies would not have been included by default.v4.4.1
Compare Source
Patch Changes
021460e95
]:v4.4.0
Compare Source
Minor Changes
f2d433b4f
Thanks @esilverm! - Show "Include Cookies" toggle in Embedded Sandbox landing page.v4.3.3
Compare Source
Patch Changes
#7331
9de18b34c
Thanks @trevor-scheer! - Unpinnode-abort-controller
and update to latest unbreaking patch#7136
8c635d104
Thanks @trevor-scheer! - Errors reported by subgraphs (with no trace data in the response) are now accurately reflected in the numeric error stats.Operations that receive errors from subgraphs (with no trace data in the response) are no longer sent as incomplete, error-less traces.
Note: in order for this fix to take effect, your
@apollo/gateway
version must be updated to v2.3.1 or later.v4.3.2
Compare Source
Patch Changes
#7314
f246ddb71
Thanks @trevor-scheer! - Add an__identity
property toHeaderMap
class to disallow standardMap
s (in TypeScript).This ensures that typechecking occurs on fields which are declared to accept a
HeaderMap
(notably, thehttpGraphQLRequest.headers
option toApolloServer.executeHTTPGraphQLRequest
and thehttp.headers
option toApolloServer.executeOperation
). This might be a breaking change forintegration authors, but should be easily fixed by switching from
new Map<string, string>()
tonew HeaderMap()
.#7326
e25cb58ff
Thanks @trevor-scheer! - Pinnode-abort-controller
version to avoid breaking change. Apollo Server users can enter a broken state if they update their package-lock.json due to a breaking change in a minor release of the mentioned package.Ref: https://github.com/southpolesteve/node-abort-controller/issues/39
Updated dependencies [
e0f959a63
]:v4.3.1
Compare Source
Patch Changes
#7313
ec28b4b33
Thanks @vtipparam! - Allow case insensitive lookup on headers. Use HeaderMap instead of plain Map for headers in expressMiddleware.#7311
322b5ebbc
Thanks @axe-me! - Export intermediate ApolloServerOptions* types#7274
3b0ec8529
Thanks @patrick91! - The subgraph spec has evolved in Federation v2 such that the type of_Service.sdl
(formerly nullable) is now non-nullable. Apollo Server nowdetects both cases correctly in order to determine whether to:
ApolloServerPluginInlineTrace
pluginApolloServerPluginSchemaReporting
should not be installedApolloServerPluginUsageReporting
is installed and configured with the__onlyIfSchemaIsNotSubgraph
optionv4.3.0
Compare Source
Minor Changes
d7e9b9759
Thanks @glasser! - If the cache you provide to thepersistedQueries.cache
option is created withPrefixingKeyValueCache.cacheDangerouslyDoesNotNeedPrefixesForIsolation
(new in@apollo/[email protected]
), theapq:
prefix will not be added to cache keys. Providing such a cache tonew ApolloServer()
throws an error.Patch Changes
#7232
3a4823e0d
Thanks @glasser! - Refactor the implementation ofApolloServerPluginDrainHttpServer
's grace period. This is intended to be a no-op.#7229
d057e2ffc
Thanks @dnalborczyk! - Improve compatibility with Cloudflare workers by avoiding the use of the Nodeutil
package. This change is intended to be a no-op.#7228
f97e55304
Thanks @dnalborczyk! - Improve compatibility with Cloudflare workers by avoiding the use of the Nodeurl
package. This change is intended to be a no-op.#7241
d7e9b9759
Thanks @glasser! - For ease of upgrade from the recommended configuration of Apollo Server v3.9+, you can now passnew ApolloServer({ cache: 'bounded' })
, which is equivalent to not providing thecache
option (as a bounded cache is now the default in AS4).v4.2.2
Compare Source
Patch Changes
2042ee761
Thanks @glasser! - Fix v4.2.0 (#7171) regression where"operationName": null
,"variables": null
, and"extensions": null
in POST bodies were improperly rejected.v4.2.1
Compare Source
Patch Changes
#7187
3fd7b5f26
Thanks @trevor-scheer! - Update@apollo/utils.keyvaluecache
dependency to the latest patch which correctly specifies its version oflru-cache
.Updated dependencies [
3fd7b5f26
]:v4.2.0
Compare Source
Minor Changes
#7171
37b3b7fb5
Thanks @glasser! - If a POST body contains a non-stringoperationName
or a non-objectvariables
orextensions
, fail with status code 400 instead of ignoring the field.In addition to being a reasonable idea, this provides more compliance with the "GraphQL over HTTP" spec.
This is a backwards incompatible change, but we are still early in the Apollo Server 4 adoption cycle and this is in line with the change already made in Apollo Server 4 to reject requests providing
variables
orextensions
as strings. If this causes major problems for users who have already upgraded to Apollo Server 4 in production, we can consider reverting or partially reverting this change.#7184
b1548c1d6
Thanks @glasser! - Don't automatically install the usage reporting plugin in servers that appear to be hosting a federated subgraph (based on the existence of a field_Service.sdl: String
). This is generally a misconfiguration. If an API key and graph ref are provided to the subgraph, log a warning and do not enable the usage reporting plugin. If the usage reporting plugin is explicitly installed in a subgraph, log a warning but keep it enabled.Patch Changes
#7170
4ce738193
Thanks @trevor-scheer! - Update @apollo/utils packages to v2 (dropping node 12 support)#7172
7ff96f533
Thanks @trevor-scheer! - startStandaloneServer: Restore body-parser request limit to 50mb (as it was in theapollo-server
package in Apollo Server 3)#7183
46af8255c
Thanks @glasser! - Apollo Server tries to detect if execution errors are variable coercion errors in order to give them acode
extension ofBAD_USER_INPUT
rather thanINTERNAL_SERVER_ERROR
. Previously this would unconditionally set thecode
; now, it only sets thecode
if nocode
is already set, so that (for example) custom scalarparseValue
methods can throw errors with specificcode
s. (Note that a separate graphql-js bug can lead to these extensions being lost; see https://github.com/graphql/graphql-js/pull/3785 for details.)Updated dependencies [
4ce738193
,45856e1dd
]:v4.1.1
Compare Source
Patch Changes
#7118
c835637be
Thanks @glasser! - Provide newGraphQLRequestContext.requestIsBatched
field to gateways, because we did add it in a backport to AS3 and the gateway interface is based on AS3.Updated dependencies [
c835637be
]:Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.