Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: limit usage of h1 per page to one #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffascript
Copy link

fix for #136

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2022

CLA assistant check
All committers have signed the CLA.

<div id="header-text">
{{ block "header" . }}
{{ with .Title }}<h2 class="large-title">{{ . }}</h2>{{ end }}
{{ with .Params.subtitle }}<h1 class="subtitle">{{ . }}</h1>{{ end }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ with .Title }}

{{ . }}

{{ end }}
{{ with .Params.subtitle }}

{{ . }}

{{ end }}

I guess Title should make use of h1 rather than subtitle

Copy link

@harshsingh32 harshsingh32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants