Merge pull request #1729 from twitter/oscar/opt-counters

Use a null check rather than foreach
twitter · Sep 27, 2017 · 19c8881 · 19c8881
2 parents 4b6c927 + 6de1884
commit 19c8881
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/scalding-core/src/main/scala/com/twitter/scalding/Stats.scala b/scalding-core/src/main/scala/com/twitter/scalding/Stats.scala
@@ -65,12 +65,14 @@ private[scalding] final case class GenericFlowPCounterImpl(fp: FlowProcess[_], s
 }
 
 private[scalding] final case class HadoopFlowPCounterImpl(fp: HadoopFlowProcess, statKey: StatKey) extends CounterImpl {
-  private[this] val counter: Option[Counter] = (for {
+  // we use a nullable type here for efficiency
+  private[this] val counter: Counter = (for {
     r <- Option(fp.getReporter)
     c <- Option(r.getCounter(statKey.group, statKey.counter))
-  } yield c)
+  } yield c).orNull
 
-  override def increment(amount: Long): Unit = counter.foreach(_.increment(amount))
+  override def increment(amount: Long): Unit =
+    if (counter != null) counter.increment(amount) else ()
 }
 
 object Stat {