Fix audio glitching when audio is late

twvd · Nov 23, 2024 · cb4882f · cb4882f
1 parent bc60e0c
commit cb4882f
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/frontend_tui/src/renderer_sdl.rs b/frontend_tui/src/renderer_sdl.rs
@@ -152,14 +152,20 @@ impl SDLEventPump {
 
 pub struct SDLAudioSink {
     recv: AudioReceiver,
+    last_sample: u8,
 }
 
 impl AudioCallback for SDLAudioSink {
     type Channel = u8;
 
     fn callback(&mut self, out: &mut [u8]) {
         if let Ok(buffer) = self.recv.try_recv() {
+            self.last_sample = buffer.last().copied().unwrap();
             out.copy_from_slice(&buffer);
+        } else {
+            // Audio is late. Continue the last output sample to reduce
+            // pops and other abrupt noises.
+            out.fill(self.last_sample);
         }
     }
 }
@@ -181,7 +187,10 @@ impl SDLAudioSink {
             let device = audio_subsystem
                 .open_playback(None, &spec, |spec| {
                     debug!("Audio spec: {:?}", spec);
-                    Self { recv: audioch }
+                    Self {
+                        recv: audioch,
+                        last_sample: 0,
+                    }
                 })
                 .map_err(|e| anyhow!(e))?;
             device.resume();