Make null param error more informative (#809) #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatcwang
reviewed
Nov 21, 2024
| @@ -56,7 +56,7 @@ sealed abstract class Put[A]( | |||
| ) {} | |||
|
|
|||
| def unsafeSetNonNullable(ps: PreparedStatement, n: Int, a: A): Unit = | |||
| if (a == null) sys.error("oops, null") | |||
| if (a == null) sys.error("Expected non-nullable param. Use Option to describe nullable values.") | |||
There was a problem hiding this comment.
Thanks nice and simple :)
We can put n into the error message to provide an even friendlier error message. Since this is all under the if clause we won't pay the cost of constructing the string until the null case is encountered.
ulfryk
force-pushed
the
fix/uninformative-null-error-simple
branch
from
55193d6
to
aab920f
Compare
|
Thanks a lot! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2141 but in the simplest possible manner.