Add service descriptor to code generator #616
Conversation
| .call(serviceClient) | ||
| .newline | ||
| .call(serviceBinding) | ||
| .outdent | ||
| .newline | ||
| .add("}") | ||
|
|
||
| private[this] def serviceDescriptor: PrinterEndo = { | ||
| _.add(s"def serviceDescriptor: ${Fs2GrpcServicePrinter.constants.ServiceDescriptor} = ${service.grpcDescriptor.fullName}") |
There was a problem hiding this comment.
The ${Fs2GrpcServicePrinter.constants.ServiceDescriptor} is to avoid conflicts with import com.google.protobuf.Descriptors.{MethodDescriptor, ServiceDescriptor}
Gorzen
force-pushed
the
add-service-descriptor
branch
2 times, most recently
from
d451399 to
8b9e0e0
Compare
Gorzen
force-pushed
the
add-service-descriptor
branch
2 times, most recently
from
d451399 to
8b9e0e0
Compare
|
Hi @ahjohannessen , Would you have time to have a look at this PR? It exposes the service descriptor to the generated gRPC service companion objects. There could be alternative implementation or naming, but the core idea of linking the |
Gorzen
force-pushed
the
add-service-descriptor
branch
from
8b9e0e0 to
8607cdf
Compare
|
please fix mima by adding |
Gorzen
force-pushed
the
add-service-descriptor
branch
from
8607cdf to
ab4831b
Compare
|
Thank you! @ahjohannessen |
|
@Gorzen np - I have made a new release |
This PR adds service descriptor in the code generator for gRPC services.
The service descriptor is useful to get general information about the service. For instance, in our case, we use the name to load the service's configuration.