Add javaOutputVersion to ScalacOptions for scala >= 3.1.2 #122
Conversation
| /** Compile for a specific version of the Java platform. Supported targets: 8, 9, ..., 17, 18. | ||
| * | ||
| * The release flag is supported only on JDK 9 and above, since it relies on the functionality | ||
| * provided in [[http://openjdk.java.net/jeps/247 JEP-247: Compile for Older Platform Versions]]. | ||
| */ | ||
| @deprecated("Use javaOutputVersion instead", "3.1.2") |
There was a problem hiding this comment.
This need to be removed and instead the line below:
version => JavaMajorVersion.javaMajorVersion >= 9 && version >= V2_12_5
needs to be changed to:
version => JavaMajorVersion.javaMajorVersion >= 9 && version >= V2_12_5 && version < V3_1_2
There was a problem hiding this comment.
Or maybe not since there is an alias for backcompat?
There was a problem hiding this comment.
Thank you, I've made those changes.
There was a problem hiding this comment.
@satorg No rush but maybe we could look into this before cutting a release?
There was a problem hiding this comment.
Sorry it should be:
version => JavaMajorVersion.javaMajorVersion >= 9 && version.between(V2_12_5, V3_1_2)
But again not sure if we should disable it yet because that flag is still working. Any opinion @TonioGela @satorg @armanbilge?
There was a problem hiding this comment.
ok fixed, but I take your point about disabling or not.
There was a problem hiding this comment.
I think if We disable this for scala > 3.1.2, it may cause some suprise for users as it takes no effect. So, I think We should not disable it.
There was a problem hiding this comment.
Yeah, let's keep it then. People will get the warning if there is one and we can remove it once the compiler removes it.
Scala 3.1.2 renamed
-releaseto-java-output-version. See blog.I'm not very confident that this PR is right but, WDYT?