Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to begin addressing #46.
The solution uses mutability since essentially the APIs ask you to (the only alternative is traversing the entire document multiple times).
The solution is also naive and it's merely syntactical: once it finds the expression
Right(())
searches for one of those imports in any point of the document:and if any of those is present it DOESN'T add the
cats.syntax.either._
import.A nice rework could include:
scala.util.Right.apply
parent
trees. If any of the occurrences doesn't have those imports in the chain of parent trees then adding a global import is more reasonable (despite the fact that it could always clash with a local import).