This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
fix bug: issue #148 #149
Merged
fix bug: issue #148 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncovercash The github action somehow fails but I'm not sure what the problem is. Is this concerning? |
|
@Nhanna I can't see it on my phone, but I'm guessing the unit test for this is failing (since it probably passed in the previous (incorrect) property). I'd go check and update the corresponding unit test |
Oh yeah, my bad. I'll go update that |
ncovercash
approved these changes
Sep 14, 2023
|
Kudos, SonarCloud Quality Gate passed! |
nhanaa
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.