[146] Other Checkbox #448
Merged
[146] Other Checkbox #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 885d668): https://bt-web-dev-ebf17--pr448-other-checkbox-ha6z5qgt.web.app (expires Mon, 04 Sep 2023 03:02:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a1bf7afe94c954469059b9e3898cf94f4178c379 |
|
I think we need some way of ensuring ppl know how to format their response. I.e smt that tells them separate using commas |
|
Also a quick comment on what otherData is would be nice to avoid having to look into OtherCheckbox to investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #146
👷 Changes: Added other checkbox component, as well as submission check.
💭 Notes: There is a lot of code duplication in the form components, make a ticket to refactor components for less duplication
Screen.Recording.2023-08-27.at.4.59.49.PM.mov
Screen.Recording.2023-08-27.at.5.40.56.PM.mov
Checklist