Add additional metrics for hyperthreaded cores in CpuUsage plugin #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the virtual-to-physical ratio of a hyperthreaded core to be specified in a config file.
mzhou0
changed the title
jpwhite4
reviewed
Aug 4, 2021
src/supremm/summarize.py
Outdated
| @@ -47,6 +49,10 @@ def __init__(self, preprocessors, analytics, job, config, fail_fast=False): | |||
| self.start = time.time() | |||
| self.archives_processed = 0 | |||
| self.fail_fast = fail_fast | |||
| if resconfig is not None and 'hyperthreaded_ratio' in config._config['resources'][resconfig['name']]: | |||
There was a problem hiding this comment.
Suggested change
| if resconfig is not None and 'hyperthreaded_ratio' in config._config['resources'][resconfig['name']]: | |
| if resconfig is not None and 'hyperthreaded_ratio' in resconfig: |
jpwhite4
reviewed
Aug 4, 2021
src/supremm/summarize.py
Outdated
| @@ -47,6 +49,10 @@ def __init__(self, preprocessors, analytics, job, config, fail_fast=False): | |||
| self.start = time.time() | |||
| self.archives_processed = 0 | |||
| self.fail_fast = fail_fast | |||
| if resconfig is not None and 'hyperthreaded_ratio' in config._config['resources'][resconfig['name']]: | |||
| self.hyperthreadedratio = config._config['resources'][resconfig['name']]['hyperthreaded_ratio'] | |||
There was a problem hiding this comment.
Suggested change
| self.hyperthreadedratio = config._config['resources'][resconfig['name']]['hyperthreaded_ratio'] | |
| self.hyperthreadedratio = resconfig['hyperthreaded_ratio'] |
6 tasks
A resource config is passed as an additional argument to the Summarize class. This can make it easier to directly access a config value for the resource being used.
|
This needs corresponding changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CpuUsage plugin now generates additional metrics when hyperthreading is on. Hyperthreading is indicated by providing the ratio of virtual/physical cores in a config file.