-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test namespaces #98
Open
aaronweeden
wants to merge
5
commits into
ubccr:xdmod11.0
Choose a base branch
from
aaronweeden:refactor-test-namespaces
base: xdmod11.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
2 times, most recently
from
October 20, 2023 17:45
b8448a2
to
58ba43b
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
4 times, most recently
from
December 8, 2023 16:05
54ae0b2
to
d147ea2
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
5 times, most recently
from
December 8, 2023 19:03
9e55771
to
a596514
Compare
6 tasks
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
2 times, most recently
from
December 8, 2023 19:38
36536fd
to
e7ee800
Compare
aaronweeden
requested review from
eiffel777,
jpwhite4,
nsimakov,
ryanrath,
connersaeli and
aestoltm
December 8, 2023 22:22
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
2 times, most recently
from
January 16, 2024 19:12
b2cd96a
to
0b0889b
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
from
February 20, 2024 16:03
0b0889b
to
33b3ef7
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
from
May 6, 2024 12:52
33b3ef7
to
b24c76c
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
from
May 28, 2024 15:41
b24c76c
to
30a96a4
Compare
aaronweeden
force-pushed
the
refactor-test-namespaces
branch
from
December 2, 2024 20:01
30a96a4
to
cb23c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as ubccr/xdmod#1789 but for the
xdmod-appkernels
module.This PR also renames
integration_tests
tointegration
to be consistent with the mainxdmod
module.This PR also fixes expected results from the integration tests.
Tests performed
To make sure the changes in this PR don't affect the tests that are run, I did the following in a Docker container running
tools-ext-01.ccr.xdmod.org/xdmod-10.5.0-x86_64:rockylinux8.5-0.3
:/unit-{before,after}.txt
and make sure the only differences are namespace names and amount of time the tests ran.Types of changes
Checklist: