Fix how pdoAggregator logs the day that was aggregated.
#1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
requested review from
eiffel777,
jpwhite4,
ryanrath,
connersaeli and
aestoltm
aaronweeden
force-pushed
the
fix-period-display
branch
from
b6a2e2b
to
a779c92
Compare
|
is this supposed to go into 11.0.1 or 11.5.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if
pdoAggregatoris used to aggregate a single day, the day it displays in the log is off by one. I noticed this when manually aggregating a day (2016-11-01) of Gateways data:That should instead be
01 11 2016.This is because the
Y00zformat string counts days of the year starting at zero, but MySQLDAYOFYEARcounts starting at one.This PR fixes how the day is displayed.
Tests performed
Tested by aggregating a day of Gateways records on
xdmod-devand confirming the displayed day is correct.Checklist: