Utf8 support #1948
Draft
Utf8 support #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
force-pushed
the
utf8_support
branch
from
e805cf9
to
f30a436
Compare
The filter string was filtering out valid values for the Report Generator delivery mode. This results in the valid string "E-mail" being converted to a null which then getes converted to "E-mail" on the sql load if the sql_mode is set empty. _Sigh_
Null is not an allowed value for the not null foreign keys to the organization and person tables. This change initializes them to a valid value (-1 == Unknown)
You can't call SQL function in PDO parameters. This code changes it so the that call to the MySQL NOW() function is done good and proper like.
The physical_usage column in the fact table is nullable, but the one in the aggregates table is not. This updates the load SQL to coalesce the null to 0 if necessary.
jpwhite4
force-pushed
the
utf8_support
branch
from
02cb605
to
08c6131
Compare
jpwhite4
force-pushed
the
utf8_support
branch
from
08c6131
to
6085568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Tests performed
Checklist: