-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Pages #17
Refactored Pages #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your hard work! I have made some suggestions on refactoring and renaming some of the components, please take a look at the comments for details. Another thing left to do would be to connect the upload photo button to the transcriptions API endpoint, and be able to display the response from that call on the frontend.
Please let me know if you have any questions.
…xed some minor css styling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job with connecting the transcriptions with the upload button! Don't need to implement this just now, but something to consider for next steps is that the api request only accepts one image. If a user uploads multiple images on the frontend, we will need to make a request for each image and combine the results.
Transcription Endpoint
Screen.Recording.2024-12-05.at.4.52.02.PM.mov
Upload Page
Screen.Recording.2024-12-01.at.3.47.21.AM.mov
Main Pages
Screen.Recording.2024-12-03.at.7.19.42.PM.mov
Log Code Page
Screen.Recording.2024-11-28.at.7.02.45.PM.mov
Summary
This PR is an extension of my last closed PR. Using the updated main branch, which includes the new Navbar and AppBar, I implemented several pages based on the provided Figma designs. Key updates and improvements in this PR include:
Refactored Pages:
Login and Signup pages have been refactored, addressing and resolving all comments from the previous PR.
New Pages:
Implemented the Main Home, Log, Log Code, and History pages based on the Figma design.
Reusable Components:
Created reusable components for the Content Header in /logbooks and /history to enhance consistency across pages.
Next Steps
Perform a thorough code cleanup to remove any unused code and improve readability.
Develop additional reusable components to further streamline the codebase.
Refactor the rest of the pages.