Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Pages #17

Merged
merged 18 commits into from
Dec 6, 2024
Merged

Refactored Pages #17

merged 18 commits into from
Dec 6, 2024

Conversation

naheyansheikh
Copy link
Contributor

@naheyansheikh naheyansheikh commented Nov 29, 2024

Transcription Endpoint

Screen.Recording.2024-12-05.at.4.52.02.PM.mov

Upload Page

Screen.Recording.2024-12-01.at.3.47.21.AM.mov

Main Pages

Screen.Recording.2024-12-03.at.7.19.42.PM.mov

Log Code Page

Screen.Recording.2024-11-28.at.7.02.45.PM.mov

Summary
This PR is an extension of my last closed PR. Using the updated main branch, which includes the new Navbar and AppBar, I implemented several pages based on the provided Figma designs. Key updates and improvements in this PR include:

Refactored Pages:
Login and Signup pages have been refactored, addressing and resolving all comments from the previous PR.

New Pages:
Implemented the Main Home, Log, Log Code, and History pages based on the Figma design.

Reusable Components:
Created reusable components for the Content Header in /logbooks and /history to enhance consistency across pages.

Next Steps
Perform a thorough code cleanup to remove any unused code and improve readability.
Develop additional reusable components to further streamline the codebase.
Refactor the rest of the pages.

@naheyansheikh naheyansheikh marked this pull request as ready for review December 1, 2024 12:45
@naheyansheikh naheyansheikh marked this pull request as draft December 4, 2024 02:11
@naheyansheikh naheyansheikh marked this pull request as ready for review December 4, 2024 03:27
@naheyansheikh naheyansheikh changed the title Draft of Refactored Pages Refactored Pages Dec 4, 2024
Copy link
Contributor

@TonyLiu0226 TonyLiu0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your hard work! I have made some suggestions on refactoring and renaming some of the components, please take a look at the comments for details. Another thing left to do would be to connect the upload photo button to the transcriptions API endpoint, and be able to display the response from that call on the frontend.

Please let me know if you have any questions.

frontend/src/components/Home/Header/WelcomeSection.jsx Outdated Show resolved Hide resolved
frontend/src/components/Home/LeftSection/BottomSection.jsx Outdated Show resolved Hide resolved
frontend/src/components/Home/LeftSection/BottomSection.css Outdated Show resolved Hide resolved
frontend/src/components/Home/LeftSection/MainContent.jsx Outdated Show resolved Hide resolved
frontend/src/components/Home/LeftSection/MainContent.css Outdated Show resolved Hide resolved
frontend/src/pages/home/Home.css Outdated Show resolved Hide resolved
frontend/src/pages/login/Login.jsx Outdated Show resolved Hide resolved
frontend/src/components/ContentHeader/ContentHeader.jsx Outdated Show resolved Hide resolved
frontend/src/pages/log_code/LogCode.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@TonyLiu0226 TonyLiu0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job with connecting the transcriptions with the upload button! Don't need to implement this just now, but something to consider for next steps is that the api request only accepts one image. If a user uploads multiple images on the frontend, we will need to make a request for each image and combine the results.

@naheyansheikh naheyansheikh merged commit 4d59ef8 into main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants