Revise internal cardinality metrics #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 47.85% 47.95% +0.09%
==========================================
Files 64 64
Lines 5993 6006 +13
==========================================
+ Hits 2868 2880 +12
- Misses 2685 2686 +1
Partials 440 440 ☔ View full report in Codecov by Sentry. |
shaan420
requested changes
Jan 5, 2024
brawndou
force-pushed
the
dev
branch
3 times, most recently
from
577999a to
9e18de7
Compare
shaan420
requested changes
Jan 10, 2024
scope_registry.go
Outdated
| counterCardinalityName = "tally.internal.counter_cardinality" | ||
| gaugeCardinalityName = "tally.internal.gauge_cardinality" | ||
| histogramCardinalityName = "tally.internal.histogram_cardinality" | ||
| scopeCardinalityName = "tally.internal.scope_cardinality" |
There was a problem hiding this comment.
num-active-scopes would be a better name for this.
shaan420
approved these changes
Jan 13, 2024
brawndou
added a commit
to brawndou/tally
that referenced
this pull request
Jan 23, 2024
* update internal metrics impl * change scope counter name
brawndou
added a commit
to brawndou/tally
that referenced
this pull request
Jan 26, 2024
* update internal metrics impl * change scope counter name
brawndou
added a commit
to brawndou/tally
that referenced
this pull request
Jan 26, 2024
* update internal metrics impl * change scope counter name
Merged
brawndou
added a commit
that referenced
this pull request
Jan 26, 2024
* Revise internal cardinality metrics (#241) * Backport #221 and #222 to master branch (#243) * [bug] Ensure that parent scopes do not return closed subscopes (#221) * TestScope: don't prune from registry when closed (#222) --------- Co-authored-by: Matt Way <[email protected]> --------- Co-authored-by: Matt Way <[email protected]>
|
This reintroduced #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revises what and how cardinality metrics are reported.
Changes:
tally.internal.to be consistent with others