Skip to content

Commit

Permalink
fix nullability of new methods
Browse files Browse the repository at this point in the history
  • Loading branch information
armughan11 committed Oct 7, 2024
1 parent 41a0371 commit a08ae75
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions nullaway/src/main/java/com/uber/nullaway/NullAway.java
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,6 @@ private static boolean isDeclarationAnnotation(Symbol anno) {
if (target == null) {
return true;

Check warning on line 1522 in nullaway/src/main/java/com/uber/nullaway/NullAway.java

View check run for this annotation

Codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/NullAway.java#L1522

Added line #L1522 was not covered by tests
}
;
ImmutableSet<ElementType> elementTypes = ImmutableSet.copyOf(target.value());
// Return true only if annotation is not type-use only
return !(elementTypes.equals(ImmutableSet.of(ElementType.TYPE_USE))
Expand Down Expand Up @@ -1552,12 +1551,7 @@ private void handleNullabilityOnNestedClass(
continue;
}

Symbol annotationSymbol = ASTHelpers.getSymbol(annotation);
if (annotationSymbol == null) {
continue;
}

String qualifiedName = annotationSymbol.getQualifiedName().toString();
String qualifiedName = sym.getQualifiedName().toString();
if (!isNullableAnnotation(qualifiedName, config)) {
continue;

Check warning on line 1556 in nullaway/src/main/java/com/uber/nullaway/NullAway.java

View check run for this annotation

Codecov / codecov/patch

nullaway/src/main/java/com/uber/nullaway/NullAway.java#L1556

Added line #L1556 was not covered by tests
}
Expand Down

0 comments on commit a08ae75

Please sign in to comment.