Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support @NonNullApi and @NonNullFields on package #1095

Closed
wants to merge 1 commit into from

Conversation

msridhar
Copy link
Collaborator

WIP

Fixes #1084

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (9ff664a) to head (13a15de).

Files with missing lines Patch % Lines
...ain/java/com/uber/nullaway/CodeAnnotationInfo.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1095      +/-   ##
============================================
- Coverage     88.01%   88.01%   -0.01%     
- Complexity     2228     2233       +5     
============================================
  Files            85       85              
  Lines          7212     7217       +5     
  Branches       1428     1430       +2     
============================================
+ Hits           6348     6352       +4     
  Misses          436      436              
- Partials        428      429       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdeleuze
Copy link

As detailed in #1084 (comment), I am not recommending that approach and think this PR should be closed unmerged.

@msridhar
Copy link
Collaborator Author

I am going to close this, but I'll leave the branch up for now in case @xenoterracide or anyone else wants to tinker

@msridhar msridhar closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support NonNullApi/NonNullFields
2 participants