Feat/security update august 2023 #661
Conversation
…iquibot into feat/autopay-fix
…iquibot into feat/autopay-fix
Co-authored-by: アレクサンダー.eth <[email protected]>
Co-authored-by: アレクサンダー.eth <[email protected]>
…iquibot into feat/autopay-fix
Co-authored-by: アレクサンダー.eth <[email protected]>
Co-authored-by: アレクサンダー.eth <[email protected]>
…iquibot into feat/autopay-fix
Co-authored-by: アレクサンダー.eth <[email protected]>
…iquibot into feat/autopay-fix
fix: query regex
chore: new migration
* feat: check permission * Update src/handlers/payout/action.ts * Update src/helpers/issue.ts Co-authored-by: whilefoo <[email protected]> * Update src/helpers/issue.ts Co-authored-by: whilefoo <[email protected]> * feat: status check * Update src/helpers/issue.ts Co-authored-by: whilefoo <[email protected]> --------- Co-authored-by: アレクサンダー.eth <[email protected]> Co-authored-by: whilefoo <[email protected]>
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ubiquibot-production ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -46,3 +57,8 @@ export const pricingLabelLogic = async (): Promise<void> => { | |||
| logger.info(`Skipping action...`); | |||
| } | |||
| }; | |||
|
|
|||
| export const isParentIssue = (body: string) => { | |||
| const parentPattern = /-\s+\[( |x)\]\s+#\d+/; | |||
There was a problem hiding this comment.
This is just checking for a checklist? This should look for the UI element when GitHub shows that it is a "tracking issue" of other issues?
@wannacfuture bfee1dd rfc
There was a problem hiding this comment.
Yeah, usually parent issue conatins this string:
- [ ] #issue_number.
and it is checking it via regexp
There was a problem hiding this comment.
Looks like this achieved the specification. I was concerned about this UI element but perhaps it isn't necessary to implement.
|
|
||
| return res.status === 204; | ||
| } catch (e: unknown) { | ||
| logger.error(`Checking if user permisson for repo failed!, reason: ${e}`); |
There was a problem hiding this comment.
- I handled all spelling errors in Feat/cspell #643
|
Because this is urgent, and because the commits already passed pull request reviews, I'll merge now. If a fatal issue is found please do not hesitate to revert this @0xcodercrane Retroactive review required |
I will have a couple of action items against production bot in ubiquibot/production repo. |
|
These changes have been merged into the development branch as well? or @pavlovcik did a cherry-pick? |
|
I basically just merged from But I technically did it from my fork. So I branched from |
|
makes sense. you're right. |
Related #622
Cosmetic hotfix for 622 should be merged in next: #636
I had a merge conflict with
src/adapters/supabase/helpers/client.tsaround line 170-180. I accepted all incoming but I hope it didn't break anything. This should be double checked.I'm extremely tired but its urgent and here's some context that might be helpful from some diffs.