-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ung 1067 verfication #17
base: master
Are you sure you want to change the base?
Conversation
…dle/log in main()
UNG 2711
Keyservice example script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check and work on comments
examples/upp-anchoring-status.py
Outdated
if r.status_code == 200: | ||
logger.info("The UPP is known to the uBirch backend! (code: %d)" % r.status_code) | ||
|
||
jobj = json.loads(r.content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename jobj
examples/EXAMPLES.md
Outdated
- [Generating and managing a keypair](#generating-and-managing-a-keypair) | ||
- [Registering a public key](#registering-a-public-key) | ||
- [Gathering Data](#gathering-data) | ||
- [Creating an UPP](#creating-an-upp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a UPP
, not an UPP
. Please check the whole file
examples/EXAMPLES.md
Outdated
When working with `chained UPPs` it can be useful to check whether the chain is in order and valid. For | ||
this task, the [`upp-chain-checker.py`](upp-chain-checker.py) can be used. It reads in a list of UPPs, | ||
checks the signature of each UPP and compares the `prevsig` field with the `signature` of the last UPP. | ||
If at any point something doesn't match up, it will print an error message alonge with the number of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in alonge
examples/upp-creator.py
Outdated
logger.info("UPP [hex]: \"%s\"" % binascii.hexlify(self.upp).decode()) | ||
|
||
# try to write the upp | ||
with open(self.output, "wb") as fd: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change fd
to file
examples/upp-sender.py
Outdated
|
||
def store_response_upp(self) -> bool: | ||
try: | ||
with open(self.output, "wb") as fd: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change fd
to file
|
||
|
||
if __name__ == "__main__": | ||
sys.exit(Main().run()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add newline
try: | ||
logger.info("Reading the input UPP from \"%s\"" % self.input) | ||
|
||
with open(self.input, "rb") as fd: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
examples/upp-sender.py
Outdated
|
||
|
||
if __name__ == "__main__": | ||
sys.exit(Main().run()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add newline
self.assertEqual(p.verfiy_signature(UUID(bytes=unpacked[1]), message), True) | ||
self.assertEqual(hashlib.sha256(b"UBIRCH").digest(), unpacked[3]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look for legacy trackle test and comment it out
No description provided.