-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: contributing how to build #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, a part few nits, the PAM side is incomplete since we rely also on the executable that is what actually does the job.
Not sure if we should also mention how service files should be generated / copied, but it's not strictly about building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 small requests to ensure we don’t vendor and stuck Rust dependencies forever and that we install the correct dependencies for code generation.
Add mention to authd-pam Co-authored-by: Marco Trevisan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 84.38% 84.46% +0.07%
==========================================
Files 77 77
Lines 6691 6693 +2
Branches 75 75
==========================================
+ Hits 5646 5653 +7
+ Misses 731 730 -1
+ Partials 314 310 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Expanded the TODOs to proper build documentation plus some other minor fixes.
Instructions have been tested on a clean 24.04 system.
UDENG-3430