-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a trick to reduce the snap size #9
Open
sergio-costas
wants to merge
8
commits into
ubuntu:stable
Choose a base branch
from
sergio-costas:remove-unneeded-files
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 14, 2023
-
Added a trick to reduce the snap size
This trick reduces the size from 110 to 87 MBytes.
Configuration menu - View commit details
-
Copy full SHA for ef12fec - Browse repository at this point
Copy the full SHA ef12fecView commit details
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f0e87a - Browse repository at this point
Copy the full SHA 0f0e87aView commit details
Commits on Jun 16, 2023
-
Keep the stage packages in the corresponding part
Since the stage packages are installed at $CRAFT_PART_INSTALL before the BUILD stage begins, we can run the clean script in that point to remove all the duplicated files while keeping the stage packages in their corresponding part. This means that we have to run the cleaning script in each part, but since we check the files in the INSTALL folder (instead of checking all the files in the snaps and remove whichever ones match), it is still much faster than the previous method.
Configuration menu - View commit details
-
Copy full SHA for 195d59a - Browse repository at this point
Copy the full SHA 195d59aView commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f1ef57 - Browse repository at this point
Copy the full SHA 0f1ef57View commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97bfa43 - Browse repository at this point
Copy the full SHA 97bfa43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 612a250 - Browse repository at this point
Copy the full SHA 612a250View commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f68306f - Browse repository at this point
Copy the full SHA f68306fView commit details
Commits on Aug 29, 2023
-
It is still incomplete, since sound doesn't work.
Configuration menu - View commit details
-
Copy full SHA for efdf70f - Browse repository at this point
Copy the full SHA efdf70fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.