Hier constraints from different files #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that #675 commented out #626, which was one step towards getting
vlsi.inputs.hierarchical.constraints
to support meta directives.Now, module-level constraints can come from different files, as long as
vlsi.inputs.hierarchical.constraints_meta: append
is set. Each file can contain part of the constraints for a given module. This addresses most of #401 I believe.Ran thru a quick e2e mock test:
Reviewing
syn-SubModC/module_config.json
files shows the correct module-specific config andsyn-SubModC/syn-output-full.json
shows SubModC's specificvlsi.inputs.hierchical.constraints
not making it through.TODO:
vlsi.inputs.hierarchical.manual_placement_constraints
. This should be legacy and completely replaceable by usingvlsi.inputs.placement_constraints
inside the submodule's constraint dict.Related PRs / Issues
Closes #401
Type of change:
Impact:
Contributor Checklist:
master
as the base branch?poetry.lock
file if you updated the requirements inpyproject.toml
?e2e/
if this feature depends on updated plugins?