Skip to content

Commit

Permalink
Merge pull request #1615 from fudgeu/issue/1607-retire-cookie-class
Browse files Browse the repository at this point in the history
Fix #1607: Retire cookie class
  • Loading branch information
clpetersonucf authored Oct 29, 2024
2 parents e6c2c59 + 08226a0 commit 978f98b
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 104 deletions.
6 changes: 5 additions & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,8 @@ LTI_KEY="materia-production-lti-key"
#GENERATION_API_KEY=
#GENERATION_API_VERSION=
#GENERATION_API_MODEL=
#GENERATION_LOG_STATS=true
#GENERATION_LOG_STATS=true

# webserver settings =======

#IS_SERVER_HTTPS=true
7 changes: 6 additions & 1 deletion docker/.env
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,9 @@ GENERATION_API_VERSION=
# required for openai
GENERATION_API_MODEL=
# not required. stat logging is set to debug threshold
GENERATION_LOG_STATS=true
GENERATION_LOG_STATS=true

# webserver environment variables

# not required, will default to true if unset. signifies if the webserver is using HTTPS or not
IS_SERVER_HTTPS=true
3 changes: 1 addition & 2 deletions fuel/app/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
'Cache' => $materia_path.'/fuel/core/cache.php',
'Fuel\\Core\\Errorhandler' => $materia_path.'/fuel/core/errorhandler.php',
'Log' => $materia_path.'/fuel/core/log.php',
'TestCase' => $materia_path.'/fuel/core/testcase.php',
'Cookie' => $materia_path.'/fuel/core/cookie.php'
'TestCase' => $materia_path.'/fuel/core/testcase.php'
// TODO: build task that will resolve/populate all the classes in materia here
]);

Expand Down
97 changes: 0 additions & 97 deletions fuel/app/classes/materia/fuel/core/cookie.php

This file was deleted.

6 changes: 3 additions & 3 deletions fuel/app/config/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -196,18 +196,18 @@
/**
* Cookie settings
*/
// 'cookie' => array(
'cookie' => array(
// Number of seconds before the cookie expires
// 'expiration' => 0,
// Restrict the path that the cookie is available to
// 'path' => '/',
// Restrict the domain that the cookie is available to
// 'domain' => null,
// Only transmit cookies over secure connections
// 'secure' => false,
'secure' => filter_var($_ENV['IS_SERVER_HTTPS'] ?? true, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE) ?? true,
// Only transmit cookies over HTTP, disabling Javascript access
// 'http_only' => false,
// ),
),

/**
* Validation settings
Expand Down
1 change: 1 addition & 0 deletions fuel/app/config/session.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@
]
],
'expiration_time' => $_ENV['SESSION_EXPIRATION'] ?? null,
'cookie_same_site' => 'None',
];

0 comments on commit 978f98b

Please sign in to comment.