CTP-3563 require impl set_submission_data()

ucl-isd · Oct 15, 2024 · 7a7e3bb · 7a7e3bb
1 parent 4d19ba0
commit 7a7e3bb
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/classes/submission/assign.php b/classes/submission/assign.php
@@ -61,7 +61,7 @@ protected function set_module_instance() {
      * @throws \dml_exception
      * @throws \moodle_exception
      */
-    protected function set_submission_data() {
+    protected function set_submission_data(): void {
         $this->submissiondata = $this->get_assign_submission();
     }
 

diff --git a/classes/submission/hvp.php b/classes/submission/hvp.php
@@ -63,7 +63,6 @@ protected function set_module_instance() {
      * {@see \local_sitsgradepush\manager::push_submission_log_to_sits()}
      * We get the item time from the gradebook.  (We don't have submissions stored in the mod_hvp local tables).
      * @return void
-     * @see
      */
     protected function set_submission_data(): void {
         $grades = grade_get_grades(

diff --git a/classes/submission/quiz.php b/classes/submission/quiz.php
@@ -63,7 +63,7 @@ protected function set_module_instance() {
      * @throws \dml_exception
      * @throws \moodle_exception
      */
-    protected function set_submission_data() {
+    protected function set_submission_data(): void {
         $this->submissiondata = $this->get_best_attempt();
     }
 

diff --git a/classes/submission/submission.php b/classes/submission/submission.php
@@ -166,6 +166,14 @@ public function get_submission_data() {
         return $this->submissiondata;
     }
 
+    /**
+     * Set submission data.
+     * The submission log transfer will be skipped without this data.
+     * {@see \local_sitsgradepush\manager::push_submission_log_to_sits()}
+     * @return void
+     */
+    abstract protected function set_submission_data(): void;
+
     /**
      * Get ISO 8601 format datetime.
      *

diff --git a/classes/submission/turnitintooltwo.php b/classes/submission/turnitintooltwo.php
@@ -61,7 +61,7 @@ protected function set_module_instance() {
      * @throws \dml_exception
      * @throws \moodle_exception
      */
-    protected function set_submission_data() {
+    protected function set_submission_data(): void {
         $this->submissiondata = $this->get_turnitintooltwo_submission();
     }