Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_ext function to return Null or Default value #7

Closed
wants to merge 1 commit into from
Closed

Update get_ext function to return Null or Default value #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gdc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,10 @@ def get_ext(file_name):

# https://github.com/broadinstitute/gdctools/blob/master/gdctools/lib/meta.py
name_list = file_name.split('.')
for i in range(len(name_list)):
if name_list[i] in _SUPPORTED_FILE_TYPES:
break
return '.'.join(name_list[i:])
for name in name_list:
if name in _SUPPORTED_FILE_TYPES:
return name
return None # todo here I have returned a None object, but for any default extension we can return as thus [return "pdf(or any defaults)"]


def mkdir_p(dir_name):
Expand Down