Transformer: move @tiptap/core to peerDependencies #865
+575
−525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump @tiptap versions
nperez0111
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Shouldn't these deps just have a looser version range like ^2?
There was a problem hiding this comment.
That would probably be fine. We'd still need to keep @tiptap/core in peerDependencies to prevent version mismatch I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tiptap core peer dependency to prevent discrepancy between version used by transformer and version used by project that relies on transformer.