Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of addToHistory for collaboration extension #3945

Conversation

codewitch
Copy link

@codewitch codewitch commented Apr 7, 2023

Please describe your changes

Tiptap editors with collaboration extensions ignores the addToHistory meta data since it uses the y-prosemirror history stack instead. However! the recent updates to y-prosemirror honors the addToHistory meta data. see the y-prosemirror readme here. Tiptap is currently at the y-prosemirror version 1.0.20 and the fix was finalized at 1.1.3.

How did you accomplish your changes

This PR updates the version to 1.1.3!

How have you tested your changes

I played around with the collaboration demo in the deploy preview and the editor is working well!

How can we verify your changes

How do you recommend I confirm the addToHistory for collaboration extension fix with this branch?

Remarks

you can see the changes in y-prosemirror's releases that the changelog from 1.0.20 to 1.1.3 are few and fairly minor.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit bcec196
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/642f6c8fc66e7000087084af
😎 Deploy Preview https://deploy-preview-3945--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codewitch codewitch changed the title upgrade y-prosemirror to 1.1.3 to allow usage of addToHistory. Allow usage of addToHistory for collaboration extension Apr 7, 2023
@svenadlung svenadlung self-requested a review April 12, 2023 06:04
@michelmar
Copy link

@bdbch Can you look into this?

@svenadlung svenadlung requested a review from bdbch August 4, 2023 15:32
@bdbch
Copy link
Member

bdbch commented Aug 5, 2023

We're a bit more cautious with package updates but we'll look into this!

@svenadlung do you have any second thoughts about this which we should take to the Hocuspocus team for further discussion (if new y-prosemirror versions have known issues with our backend, etc.?)

@romansp
Copy link
Contributor

romansp commented Sep 13, 2023

Raising awaraness here about an existing issue in y-prosemirror history implementation where addToHistory: false could be ignored if it comes from appendedTransaction meta. yjs/y-prosemirror#141

Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janthurau @svenadlung do you see any issues with that y-prosemirror version and one of our collab packages?

@bdbch bdbch requested a review from janthurau April 6, 2024 02:03
@nperez0111
Copy link
Contributor

We've upgraded past this since

@nperez0111 nperez0111 closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants