Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): if a transaction is a no-op do not attempt to re-apply it #4535 #5449

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Aug 6, 2024

Changes Overview

Do not attempt to reapply events which result in the same editor state

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

#4535

Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: c882215

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit c882215
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6744a99ee76f190008e647f4
😎 Deploy Preview https://deploy-preview-5449--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111
Copy link
Contributor Author

What about appended transactions: #4535 (comment)

@nperez0111 nperez0111 marked this pull request as ready for review November 25, 2024 16:45
Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@5449

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@5449

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@5449

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@5449

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@5449

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@5449

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@5449

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@5449

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@5449

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@5449

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@5449

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@5449

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@5449

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@5449

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@5449

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@5449

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@5449

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@5449

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@5449

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@5449

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@5449

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@5449

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@5449

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@5449

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@5449

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@5449

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@5449

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@5449

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@5449

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@5449

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@5449

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@5449

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@5449

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@5449

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@5449

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@5449

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@5449

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@5449

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@5449

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@5449

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@5449

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@5449

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@5449

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@5449

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@5449

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@5449

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@5449

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@5449

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@5449

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@5449

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@5449

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@5449

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@5449

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@5449

commit: c882215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

2 participants