-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rotational intertia calculation script #94
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 5 5
Lines 1366 1366
=======================================
Hits 1252 1252
Misses 114 114 ☔ View full report in Codecov by Sentry. |
Good starting point, but you can get all vectors from the settings file. So the script should print the resulting inertia based on the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is missing is a main program, that calls one of your functions and prints the result. OK, I see you print the results in one of the functions. But this is not so good, a function that has a name starting with calculate_... should not print anything.
…iteModels.jl into rotation_inertia_calculation
Solution to issue