Skip to content

Commit

Permalink
refactor: pull request feedback
Browse files Browse the repository at this point in the history
thanks @wridgeu!
  • Loading branch information
vobu committed Sep 4, 2023
1 parent 5233600 commit 5d2b27f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion docs/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ WebdriverIO now automates downloading and starting the appropriate driver corres
}]
```

Setting `broswerName: "chrome"` is enough to tell `wdi5`/`wdio` to run the tests with the stable version of Chrome - no more `"chromedriver"` needed in the `services`!
Setting `browserName: "chrome"` is enough to tell `wdi5`/`wdio` to run the tests with the stable version of Chrome - no more `"chromedriver"` needed in the `services`!
To switch to Safari on macOS, following the above example is as easy as changing the `browserName`:

```js
Expand Down
2 changes: 1 addition & 1 deletion docs/recipes.md
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ it("should find the search button on a SearchField", async () => {

## using wdio functions

WebdriverIO has an extensive element [API](https://webdriver.io/docs/api/). The [Element API](https://webdriver.io/docs/api/element) specifically can be quite useful to check if the page elements are in a certain state e.g. [isDisplayed](https://webdriver.io/docs/api/element/isDisplayed) or [isClickable](https://webdriver.io/docs/api/element/isClickable).
WebdriverIO has an extensive [API](https://webdriver.io/docs/api/). The [Element API](https://webdriver.io/docs/api/element) specifically can be quite useful to check if the page elements are in a certain state e.g. [isDisplayed](https://webdriver.io/docs/api/element/isDisplayed) or [isClickable](https://webdriver.io/docs/api/element/isClickable).

To make use of these element functions, `wdi5` allows to switch APIs from UI5 to wdio by calling `$()`.

Expand Down
4 changes: 0 additions & 4 deletions examples/ui5-js-app-esm/webapp/controller/App.controller.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
"use strict"

sap.ui.define(["test/Sample/controller/BaseController"], function (Controller) {
"use strict"

return Controller.extend("test.Sample.controller.App", {
onInit: function () {}
})
Expand Down
2 changes: 1 addition & 1 deletion examples/ui5-js-app-esm/webapp/i18n/i18n.properties
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ startPage.userButton.text=User Test Text
startPage.navButton.text=to Other view
startPage.currentUI5.text=most current UI5 version available
startPage.title.text=UI5 demo
startPage.text.username=Benutzername
startPage.text.username=Username

###

Expand Down

0 comments on commit 5d2b27f

Please sign in to comment.