-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add line plots #325
base: main
Are you sure you want to change the base?
Add line plots #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Don't forget to update any unit test that has a config with "plot_type": "generic",
at the start so we can make sure the CI is passing cleanly.
This has remained undocumented thus far, but I've been using Edit: With regards to the current failing checks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, very close to being done I think. I've just made a few more notes and noticed that a good final touch to add would be to update the README config structure and config template sections to account for the new custom axis ranges.
…ser doesn't provide any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm more or less happy with the way this PR looks now. The important functionality is all there and I don't see any more major bugs that need to be fixed. Pytest is still passing locally.
Once this gets merged, I think any of the following bits that aren't implemented here should collectively belong to some sort of line plot enhancement issue:
- Update README config structure + template sections to account for new custom axis ranges.
- Implement custom axis ranges for bar charts OR hide range selectors. (For now could also add tooltips to range selectors with this information.)
- Allow use of custom values for only one of min or max.
Adding the option to plot line charts.