[grid] Fix running the benchmark with a non supported system #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases, e.g. when running on a non supported system, attributes like `current_partition.processor.num_cpus` and `current_partition.processor.num_cpus_per_core` have value `None`, which breaks some arithmetic operations, so we use `VAR or 1` to give it a "default" value of 1. Note that all these attributes are used to the set the default values of other attributes, but they can all be overridden on the command line.
giordano
force-pushed
the
mg/grid-local
branch
from
a3d6794 to
4d92589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, e.g. when running on a non supported system, attributes like
current_partition.processor.num_cpusandcurrent_partition.processor.num_cpus_per_corehave valueNone, which breaks some arithmetic operations, so we useVAR or 1to give it a "default" value of 1. Note that all these attributes are used to the set the default values of other attributes, but they can all be overridden on the command line.