LTD-5573-make-makedown-safe-remove #2219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depsiatwal
force-pushed
the
LTD-5573-make-makedown-safe-remove
branch
from
7315a8e
to
7639562
Compare
currycoder
reviewed
Oct 30, 2024
| @@ -13,4 +13,6 @@ def back_to_task_list(application_id): | |||
|
|
|||
| def footer_label(application_id): | |||
| url = reverse("applications:task_list", kwargs={"pk": str(application_id)}) | |||
| return Label(f'Or <a class="govuk-link" href="{url}">return to application overview</a>') | |||
| return Label( | |||
| f'Or <a class="govuk-link govuk-link--no-visited-state" rel="noreferrer noopener" target="_blank" href="{url}">return to application overview</a>' | |||
There was a problem hiding this comment.
Just interested, but what is this change achieving?
There was a problem hiding this comment.
lite-frontend/lite_forms/components.py
Line 175 in c577a90
Looks like it's used to add a link to the footer.
Yes I could add it to the template and be done with. But I question how far do I go with this PR. For now the aim is to just ensure we can remove the markdown method and make it clearer where it was used and replace the constants along the way.
currycoder
reviewed
Oct 30, 2024
| DESCRIPTION = "You may know this as an 'end use control'." | ||
| DESCRIPTION = "Give the application a reference name so you can refer back to it when needed." |
There was a problem hiding this comment.
This doesn't seem right
There was a problem hiding this comment.
not sure how that got changed looks like copied from above revered back.
depsiatwal
force-pushed
the
LTD-5573-make-makedown-safe-remove
branch
from
7639562
to
2e76b97
Compare
currycoder
approved these changes
Oct 30, 2024
| @@ -155,20 +154,6 @@ def heading_used_as_label(components): | |||
| return single_input | |||
|
|
|||
|
|
|||
| def convert_to_markdown(text): | |||
depsiatwal
force-pushed
the
LTD-5573-make-makedown-safe-remove
branch
from
2e76b97
to
2da3fc8
Compare
depsiatwal
force-pushed
the
LTD-5573-make-makedown-safe-remove
branch
from
2da3fc8
to
e5d58be
Compare
saruniitr
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uktrade.atlassian.net/browse/LTD-5573
First part here is to just remove the filter_tag