Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP2000-1584 Fix duty sentence parser error with MAX expression #1335

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

TP2000-1584 Fix duty sentence parser error with MAX expression #1335

wants to merge 7 commits into from

Commits on Nov 21, 2024

  1. Remove SIDs of lower order to matched SID to ensure duty expressions … 

    …are applied in ascending order
    @dalecannon
    dalecannon committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6d59772 View commit details
    Browse the repository at this point in the history

  2. Refactor lark parser unit testing to cater for duty expression SID or… 

    …dering
    @dalecannon
    dalecannon committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    94b4539 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Track matched SIDs to provide more specific validation error messaging

    @dalecannon
    dalecannon committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e1eafa0 View commit details
    Browse the repository at this point in the history

  2. Don't mistake overused duty amount expressions as supplementary unit

    @dalecannon
    dalecannon committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e160175 View commit details
    Browse the repository at this point in the history

  3. Fix AttributeError exception

    @dalecannon
    dalecannon committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8233ef2 View commit details
    Browse the repository at this point in the history

  4. Split and extend unit tests

    @dalecannon
    dalecannon committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5b8fdda View commit details
    Browse the repository at this point in the history

  5. Factor out valid match conditional into helper boolean function

    @dalecannon
    dalecannon committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f394c1c View commit details
    Browse the repository at this point in the history