Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_domains.yml for 5 attempts #135

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 21, 2024

Increased robustness

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced domain redirection check workflow to improve reliability and accuracy.

πŸ“Š Key Changes

  • Increased the maximum number of redirection check attempts from 3 to 5.
  • Adjusted the exponential backoff delay progression to include higher wait times (up to 32 seconds).

🎯 Purpose & Impact

  • Improved Robustness: By expanding the number of redirect attempts, the system can better handle temporary network issues, reducing the need for manual retries. ⏳
  • Increased Success Rates: Longer wait times between attempts help accommodate temporary server delays, increasing the likelihood of successful redirection verification. 🌐

@UltralyticsAssistant UltralyticsAssistant added the devops GitHub Devops or MLops label Nov 21, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/docs πŸš€ PR! This is an automated response to guide you through the submission process. An Ultralytics engineer will review your PR soon. In the meantime, please ensure the following checklist is completed to facilitate a smooth review process:

  • βœ… Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description. Link any relevant issues you are addressing.
  • βœ… Synchronize with Source: Ensure your PR is up-to-date with the main branch of ultralytics/docs. Utilize the 'Update branch' button or run git pull and git merge main locally if needed.
  • βœ… Check CI Success: Confirm that all Ultralytics Continuous Integration (CI) checks pass. Address any failure points accordingly. πŸ› οΈ
  • βœ… Update Documentation: Add or modify relevant documentation to reflect changes made.
  • βœ… Include Tests: Add or update tests for your changes, ensuring all tests are functioning correctly.
  • βœ… Sign the CLA: If this is your first PR, sign the Contributor License Agreement by stating "I have read the CLA Document and I sign the CLA" in the comments.
  • βœ… Minimize Changes: Ensure your changes are limited to what is necessary. Reflect on Bruce Lee's wisdom, "Hack away the unessential." 🎯

For further information, check out our Contributing Guide. Feel free to ask any questions by leaving a comment. Thanks again for contributing to Ultralytics! ✨

@glenn-jocher glenn-jocher merged commit c6c2c2c into main Nov 21, 2024
2 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 21, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants