Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extra.js for auto theme #18

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Update extra.js for auto theme #18

merged 1 commit into from
Oct 19, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Oct 19, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved theme application process in the Ultralytics handbook documentation, simplifying the code and enhancing user experience.

πŸ“Š Key Changes

  • Consolidated functions for applying themes, reducing redundancy.
  • Simplified logic to determine and apply user-preferred themes.
  • Added event listeners for dynamic theme changes and refactored code to streamline theme management.
  • Enhanced support for multiple languages by improving language code handling in the theme process.

🎯 Purpose & Impact

  • Efficiency: Refactoring the code makes maintenance easier and reduces potential errors.
  • User Experience: Ensures seamless application of user-preferred themes, enhancing the interface's adaptability to user preferences.
  • Internationalization: Better handling of language-specific settings supports a broader, global audience more effectively.

@UltralyticsAssistant UltralyticsAssistant added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 19, 2024
@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/handbook πŸš€ PR! This is an automated response to confirm that we've received your pull request. An Ultralytics engineer will review it soon. In the meantime, please check out the following checklist to ensure a smooth collaboration:

  • βœ… Define a Purpose: Ensure the purpose of your modifications is clearly articulated in the PR description, and link to any relevant issues. Make sure your commit messages are clear, concise, and follow the project's conventions.
  • βœ… Synchronize with Source: Confirm your PR is up-to-date with the ultralytics/handbook main branch. If it's behind, update it by clicking the 'Update branch' button or by executing git pull and git merge main locally.
  • βœ… Ensure CI Checks Pass: Make sure all Ultralytics Continuous Integration (CI) checks are successful. If any checks fail, please investigate and resolve the issues.
  • βœ… Update Documentation: Reflect any new or altered features in the relevant documentation.
  • βœ… Add Tests: Where needed, add or modify tests to verify your changes, and ensure all tests pass.
  • βœ… Sign the CLA: If this is your first PR with Ultralytics, please sign our Contributor License Agreement by stating "I have read the CLA Document and I sign the CLA" in a comment below.
  • βœ… Minimize Changes: Keep your changes to the essential minimum for your feature or bug fix. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

For more helpful advice, refer to our Contributing Guide. Feel free to leave a comment if you have any questions. Thank you for your valuable contribution to Ultralytics! πŸš€πŸŽ‰

@glenn-jocher glenn-jocher merged commit d44919c into main Oct 19, 2024
1 check passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch October 19, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants