-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug in translate coords for detectImage func #70
base: main
Are you sure you want to change the base?
Conversation
👋 Hello @yangga, thank you for submitting an
For more detailed guidance, our Contributing Guide is available as a resource. Feel free to ask questions by leaving a comment directly on this PR. Thanks again for contributing to Ultralytics and helping us make our projects better! 🎉 |
@yangga thank you for the PR! Do you think we might need this change in https://github.com/ultralytics/yolo-ios-app as well? @john-rocky FYI. |
@glenn-jocher No problem. I'm not sure that https://github.com/ultralytics/yolo-ios-app needs this change. (even I couldn't find the function such as detecting image). But if that repos has this change, it gonna be helpful for someone. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenn-jocher @yangga
The modified code works correctly in cases where the aspect ratio of the input image and the display image match, such as single image input.
However, in cases where the input camera image and the display size are different, such as real-time camera inference, the existing code works better. Therefore, I think the existing code is more suitable for Yolo-iOS-app, which performs real-time inference.
There is a bug in detectImage function on iOS devices where the x coordinate is a bit weird. This PR is to fix that. And also remove unnecessary print.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improves object detection bounding box calculations for iOS devices in the YOLO Flutter app.
📊 Key Changes
🎯 Purpose & Impact