Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #394 - missing _mm256_storeu2_m128i macro #395

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

supersjgk
Copy link
Contributor

Please look at the issue #394 for exact error while installing Kvazaar.
I tried installing it on Ubuntu 20.04 (2 different machines). I only tried this version Kvazaar v2.3.0-24-ga909ddd2 2024-02-02
Apparently, the macro _mm256_storeu2_m128i definition was missing from Intel Intrinsic header, so I added it directly in kvazaar > src > strategies > avx2 > quant-avx2.c.
After that I was able to successfully install and run kvazaar to encode an mp4 video to hevc format.

@Jovasa
Copy link
Member

Jovasa commented Feb 14, 2024

Thanks, however please instead add the definition for the macro to this file https://github.com/ultravideo/kvazaar/blob/master/src/strategies/missing-intel-intrinsics.h#L22 inside the #if COMPILE_INTEL_AVX2 block and add check if the definition already exists, and include the header in the quant-avx2.c file

@supersjgk
Copy link
Contributor Author

Hello @Jovasa. I changed it as you asked. Please check my new commit if it's correct.

@Jovasa Jovasa added the safe to test Run tests on CI label Feb 16, 2024
@Jovasa
Copy link
Member

Jovasa commented Feb 16, 2024

Yep, it's good now, thanks!

@Jovasa Jovasa merged commit d8c9688 into ultravideo:master Feb 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Run tests on CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants