New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix android build #415

Merged

fador merged 1 commit into ultravideo:master from trittsv:fix-android-build

Sep 6, 2024

Contributor

trittsv commented Sep 2, 2024

This PR provides build fixes for Android.

The android build got broken in version 2.3.1.
In 2.3.0 it worked fine.

There are two build errors that are fixed with this PR for Android NDK builds:

Threads

CMake Error at /opt/homebrew/Cellar/cmake/3.25.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Threads (missing: Threads_FOUND)

muse-unaligned-vector-move

sventrittler@Svens-MBP b % cmake --build .
[  1%] Building C object CMakeFiles/kvazaar.dir/src/bitstream.c.o
clang: error: unsupported argument '-muse-unaligned-vector-move' to option 'Wa,'

May android builds should be added to the CI some day.


          fix android build

ddd2ab1

fador merged commit 6b7f065 into ultravideo:master

Member

fador commented Sep 6, 2024

Thank you! Actually the whole CMakeLists.txt is a recent addition so we are not using it at all in the CI yet 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet