feat: Listen on onion-service, dial onion services #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarybaron
force-pushed
the
feat/listen-hidden-service
branch
from
2f3020b to
fefca98
Compare
|
@umgefahren This works as a proof-of-concept. Can you take a look regarding the general direction this PR is going? |
binarybaron
changed the title
binarybaron
changed the title
|
@Einliterflasche You can give this a review as well once it's ready. |
|
I think you are going in the right direction. Although I would suggest you put this behind a feature gate |
binarybaron
force-pushed
the
feat/listen-hidden-service
branch
from
673f6ee to
f4e71fa
Compare
…es which dont match filter
|
@umgefahren @Einliterflasche This is ready for review |
binarybaron
changed the title
binarybaron
force-pushed
the
feat/listen-hidden-service
branch
from
e050f37 to
6295fba
Compare
binarybaron
force-pushed
the
feat/listen-hidden-service
branch
from
6295fba to
0a973c8
Compare
|
@umgefahren Do you have time to give this a review? |
umgefahren
approved these changes
Nov 28, 2024
Comment on lines
+133
to
+134
| // TODO: We need to do this because otherwise the status of the onion service is gonna be [`Shutdown`] | ||
| // when we first poll it and then the swarm will not pull it again (?). I don't know why this is the case. |
There was a problem hiding this comment.
Please look into this. But this can also be fixed later.
binarybaron
added a commit
to UnstoppableSwap/core
that referenced
this pull request
Dec 3, 2024
This pull requests - Adds rust native support for the `asb` to listen on an onion service. Previously we were depedent on a seperately running `torc` client. Instead we now use [arti](https://tpo.pages.torproject.net/core/arti/), a rust implementation of the tor protocol. - Removes the `tor.control_port` and `tor.socks5_port` property from the config of the `asb` - Adds a new `tor.register_hidden_service` boolean property to the config of the `asb` which when enabled automatically runs a hidden service at startup - Adds a new `tor.hidden_service_num_intro_points` config property to specify how many introduction points to register the onion service at - Adds support for the `cli` to dial onion addresses This is dependent on umgefahren/libp2p-tor#24 Closes #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for listening on onion services (
/onion3/*:x/addresses, where*is an onion address andxan arbitrary port)It also add support for dialing them.
Closes #19