fix: Immediately announce onion address to swarm #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of waiting for the onion service to be fully reachable (registered at intro points and hs_dirs), we announce the address immediately. This fixes an issue where libp2p would not poll our transport against after we did not announce an address on the first poll.
binarybaron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #31
Instead of waiting for the onion service to be fully reachable (registered at intro points and hs_dirs), we announce the address immediately.
We announce the address immediately to the swarm even though we technically cannot guarantee that the address is reachable yet from the outside. We might not have registered the onion service fully yet (introduction points, hsdir, ...)
However, we need to announce it as soon as possible because otherwise libp2p might not poll the listener again and we will not be able to announce it later.