Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hide shortcut tips for search if not empty #1939

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

crazyair
Copy link
Contributor

@crazyair crazyair commented Oct 12, 2023

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 9:35am

@crazyair crazyair closed this Dec 26, 2023
@crazyair crazyair reopened this Dec 26, 2023
@crazyair
Copy link
Contributor Author

@PeachScript 怎么样了

@PeachScript
Copy link
Member

@PeachScript 怎么样了

忘回复了,我还是倾向于 CSS 解,原因:

  1. 性能上 CSS 好过条件式渲染,虽然微乎其微
  2. CSS 方案过渡动画不会丢失

@PeachScript PeachScript changed the title fix: search not empty to hide icon refactor: hide shortcut tips for non-empty search input Dec 26, 2023
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript changed the title refactor: hide shortcut tips for non-empty search input refactor: hide shortcut tips for search if not empty Dec 26, 2023
@PeachScript PeachScript merged commit 1865b01 into umijs:master Dec 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants