Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify frontend files cache policy #1592

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Feb 5, 2023

Previously Cache-Control was set to "max-age=3600, no-cache", but max-age is not used in case no-cache is set.

cc @Ivan-Chupin for review.

Addresses #1549 (reply in thread).

Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overrides other parts of code which makes this change really confusing and hard to debug. #556 (comment)

@paskal paskal marked this pull request as draft April 2, 2023 19:17
Previously Cache-Control was set to "max-age=3600, no-cache",
but max-age is not used in case no-cache is set.
@paskal paskal force-pushed the paskal/clarify_cache_for_frontend branch from 62e6e1e to 7cc7ce4 Compare January 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants